OM-42925: Fix logging errors #60
Conversation
TestAfter the fix, the human readable pb message is printed out: |
{{ message }}
Merged
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwangvmt
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Original problem reported as follows:
I0211 15:08:18.775160 1 remote_mediation_client.go:415] [ActionMessageHandler] Received: action {%!s(*proto.MediationServerMessage_ActionRequest=&{0xc00072c000}) %!s(*int32=0xc001f58b0c) } requestfrom the following line of code:
glog.V(4).Infof("[ActionMessageHandler] Received: action %s request", serverRequest)Cause
We are trying to print out a protobuf message for debugging purpose. The protobuf message type implements the String() method that satisfies the Stringer interface, however, the method has a pointer receiver instead of a value receiver:
func (m *MediationServerMessage) String() string { return proto.CompactTextString(m) }Because we are only passing in a value of
proto.MediationServerMessage, the implemented String() method is never called.Fix